PD-5388 restore the record summary link on records with no public information - #2927
Open
cryptalith wants to merge 1 commit into
Open
PD-5388 restore the record summary link on records with no public information#2927cryptalith wants to merge 1 commit into
cryptalith wants to merge 1 commit into
Conversation
…ormation A record with no publicly visible information still has a creation date and a last-modified date, but the header's show/hide toggle was gated on `noDisplayableData`, so a visitor had no way to reach either. `summary.json` serves an empty record on its active path, so the Key dates panel was already there to show — nothing but the gate was missing. `canToggleRecordSummary` replaces that gate and refuses only records that do not exist. The two projected label spans lose their own `*ngIf`: they render inside the toggle button, so gating them left an icon with no text. Copy iD and print keep their `noDisplayableData` gate — the ticket asks for the summary link alone — and a unit test pins that boundary so a future change has to mean it. Locked, deprecated and deactivated records are a separate ticket: their `summary.json` short-circuits before the dates are read, so un-hiding the toggle there opens a blank panel. Also null-guards the three `userInfo` conditions in record-info, which renders on this same empty-record path before `userInfo` has resolved.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://orcid.clickup.com/t/9014437828/PD-5388